argocd-image-updater icon indicating copy to clipboard operation
argocd-image-updater copied to clipboard

Events not correctly sent

Open magmax opened this issue 4 years ago • 3 comments

Describe the bug Events when updating images are not correctly sent, probably because the namespace contains a hyphen -:

time="2021-09-20T10:14:47Z" level=warning msg="Event could not be sent: namespaces \"\\\"argo-cd\\\"\" not found" application=whatever

To Reproduce Steps to reproduce the behavior:

  1. deploy an application to a namespace containing hyphens
  2. configure argocd to point to that namespace
  3. try to update an image.

Expected behavior The event should be sent and no warning should appear in the log.

Additional context

Version 0.10.0

Logs

time="2021-09-20T10:14:47Z" level=warning msg="Event could not be sent: namespaces \"\\\"argo-cd\\\"\" not found" application=whatever

magmax avatar Sep 20 '21 10:09 magmax

FWIW I'm not seeing any warning logs like this but we're also running image-updater 0.10.0, and the namespace is argocd-image-updater

edit to add, I'm also not seeing events though

zswanson avatar Nov 25 '21 02:11 zswanson

I am seeing this when using image updater 0.12.0

time="2022-08-12T09:09:18Z" level=warning msg="Event could not be sent: Event \"<myapp>.170a8dd4fe160d18\" is invalid: involvedObject.namespace: Invalid value: \"argocd\": does not match event.namespace" application=<myapp>

Where I have an application name myapp in namespace myapp restricted to its own namespace. image updater and argocd deployed to their own namespaces.

andrei-dascalu avatar Aug 12 '22 09:08 andrei-dascalu