argocd-image-updater
argocd-image-updater copied to clipboard
Events not correctly sent
Describe the bug
Events when updating images are not correctly sent, probably because the namespace contains a hyphen -:
time="2021-09-20T10:14:47Z" level=warning msg="Event could not be sent: namespaces \"\\\"argo-cd\\\"\" not found" application=whatever
To Reproduce Steps to reproduce the behavior:
- deploy an application to a namespace containing hyphens
- configure argocd to point to that namespace
- try to update an image.
Expected behavior The event should be sent and no warning should appear in the log.
Additional context
Version 0.10.0
Logs
time="2021-09-20T10:14:47Z" level=warning msg="Event could not be sent: namespaces \"\\\"argo-cd\\\"\" not found" application=whatever
FWIW I'm not seeing any warning logs like this but we're also running image-updater 0.10.0, and the namespace is argocd-image-updater
edit to add, I'm also not seeing events though
I am seeing this when using image updater 0.12.0
time="2022-08-12T09:09:18Z" level=warning msg="Event could not be sent: Event \"<myapp>.170a8dd4fe160d18\" is invalid: involvedObject.namespace: Invalid value: \"argocd\": does not match event.namespace" application=<myapp>
Where I have an application name myapp in namespace myapp restricted to its own namespace. image updater and argocd deployed to their own namespaces.