graphql-tools icon indicating copy to clipboard operation
graphql-tools copied to clipboard

@graphql-tools/delegate requires TypeScript lib ESNext

Open AaronMoat opened this issue 1 year ago • 0 comments

Issue workflow progress

Progress of the issue based on the Contributor Workflow

  • [ ] 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

    Make sure to fork this template and run yarn generate in the terminal.

    Please make sure the GraphQL Tools package versions under package.json matches yours.

  • [ ] 2. A failing test has been provided
  • [ ] 3. A local solution has been provided
  • [ ] 4. A pull request is pending review

Describe the bug

I'm not sure if this counts as a bug, but after https://github.com/ardatan/graphql-tools/pull/6312, to compile the delegate library requires either of the following Typescript options:

  • "lib": ["ESNext"]
  • "skipLibCheck": true

Else the following error is emitted:

node_modules/.pnpm/@[email protected][email protected]/node_modules/@graphql-tools/delegate/typings/leftOver.d.ts(4,37): error TS2304: Cannot find name 'PromiseWithResolvers'.

This feels less than ideal to me (relying on ESNext or skipLibCheck), but might be OK if documented.

To Reproduce Steps to reproduce the behavior:

N/A

Expected behavior

N/A

Environment:

N/A

Additional context

N/A

AaronMoat avatar Jul 18 '24 10:07 AaronMoat