graphql-tools icon indicating copy to clipboard operation
graphql-tools copied to clipboard

feat: add default values handling to buildOperationNodeForField

Open uroslates opened this issue 2 years ago • 1 comments

Description

Fixes #5268 where the feature request for propagating default values when building operations for field has been elaborated.

Related # (issue)

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] run all existing tests and made sure they are not breaking
  • [x] should work with query with default value arguments
  • [x] should work with mutation with default value arguments

Test Environment:

  • OS:
  • @graphql-tools/...:
  • NodeJS:

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests and linter rules pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

uroslates avatar May 11 '23 22:05 uroslates

⚠️ No Changeset found

Latest commit: 18927cb4e83567aea514f6674085dc66b0f95169

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 11 '23 22:05 changeset-bot[bot]