graphql-tools icon indicating copy to clipboard operation
graphql-tools copied to clipboard

Draft: test(stitch): add failing test for complex computed return type

Open sondremare opened this issue 2 years ago • 1 comments

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Failing test case for issue: Adding a computed property with a non-primitive/non-scalar return type breaks the schema when stitching

Related https://github.com/ardatan/graphql-tools/issues/4956

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

Test Environment:

  • OS: macOS Monterey (12.5.1)
  • @graphql-tools/stitch": "^8.7.34,
  • @graphql-tools/stitching-directives": "^2.3.24,
  • NodeJS: 16.13.2

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests and linter rules pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

sondremare avatar Jan 10 '23 08:01 sondremare

⚠️ No Changeset found

Latest commit: a5d20ca441273c0204720d54636e648fbc7fc544

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 10 '23 08:01 changeset-bot[bot]

Sorry for late review :) After our recent changes, I think the test case you provided seems passing! Let us know if you have any further issues!

ardatan avatar May 14 '24 21:05 ardatan