graphql-tools icon indicating copy to clipboard operation
graphql-tools copied to clipboard

feat: allow addMocksToSchema to receive legacy resolver validation options

Open grxy opened this issue 3 years ago • 2 comments

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Adds a new optional parameter to addMocksToSchema that allows validation options to be passed to the underlying addResolversToSchema call.

Fixes https://github.com/ardatan/graphql-tools/issues/4434

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [X] I added a new test case that would fail without the source changes.

Test Environment:

  • OS: macOS 12.2.1
  • @graphql-tools/...: master
  • NodeJS: v14.18.1

Checklist:

  • [X] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [X] My changes generate no new warnings
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests and linter rules pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

N/A

grxy avatar May 03 '22 19:05 grxy

🦋 Changeset detected

Latest commit: 5e42ff53643012c714e964c5aa7a1823d605ace0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/mock Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 03 '22 19:05 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-tools ✅ Ready (Inspect) Visit Preview May 3, 2022 at 10:54PM (UTC)

vercel[bot] avatar May 03 '22 19:05 vercel[bot]