graphql-tools icon indicating copy to clipboard operation
graphql-tools copied to clipboard

[Feature request] Dependency injection for graphql implemataion

Open cometkim opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe.

I want to use a custom graphql implementation. use cases

  1. I wanna use @kitten 's graphql-web-lite or something other for a lighter bundle
  2. gatsby-plugin-typegen, which is based on GCG and graphql-tools should depend on the graphql module re-exported from gatsby. Otherwise, users will get build errors due to version conflicts

Both of these can be solved today only with third-party tools such as bundlers (e.g. Webpack) or package managers (e.g. Yarn).

As usual, the JS module system cannot change its configuration by itself, so if we have base dependencies externally we configure the dependency injection by hand, instead of import impl directly.

Describe the solution you'd like

The easiest option is to accept graphql impl as an optional argument in all the functions.

const { mergeSchemas } = require('@graphql-tools/schema');

mergeSchemas({
   grapqhql: myGraphQl,
   /** ... */
});

Or a better way I think is to create a builder that allows you to customize the configuration of the function.

export function createMergeSchema({ graphql }) {
   return function mergeSchema(...) { ... }
}

export const mergeSchema = createMergeSchema({ graphql })

Describe alternatives you've considered

Transpile it and bundle the entire GCG and graphql-tools...

cometkim avatar Sep 27 '21 17:09 cometkim

Quick note here that graphql-web-lite + graphql-tools probably isn't the best example, since the former is Web-focused and hence drops support here and there for the SDL. 😅

kitten avatar Sep 27 '21 17:09 kitten

Ah, i got it. Maybe it's better to find another example for SDL support. like WASM-based something?

I assume graphql-tools have broader use cases including browsers. and I would definitely put it on a service worker or cloudflare workers.

cometkim avatar Sep 27 '21 17:09 cometkim