graphql-tools icon indicating copy to clipboard operation
graphql-tools copied to clipboard

requireResolversForArgs incorrectly labelled as missing with subscription args

Open Darkbladecr opened this issue 4 years ago • 2 comments

Describe the bug When arguments are added to the subscription type on the graphQL schema the requireResolversForArgs is incorrectly erroring.

type Subscription {
  numberIncremented(id: Int): Int
}

Resolver missing for "Subscription.numberIncremented".

To Reproduce Example forked from official Apollo-server example: https://codesandbox.io/s/pensive-joliot-brxcj?file=/index.js

Expected behavior If arguments taken off the subscription type in the schema, everything works fine.

  • OS:
  • @graphql-tools/...: 7.1.5

Darkbladecr avatar Sep 22 '21 15:09 Darkbladecr

Hi @Darkbladecr and thank you for the report

Sorry but I'm not adding a lot here but just labeling it according to our new Contribution Guide and issue flow.

It seems already got into stage 1 thanks to your reproduction! Thank you for that!

Now in order to advance to stage 2 we'll need a failing test, would be great if someone could help progress the issues through the stages.

Thank you and sorry that this comment is not a complete solution (yet).

Urigo avatar Sep 23 '21 11:09 Urigo