tracee icon indicating copy to clipboard operation
tracee copied to clipboard

ebpf: remove bufs_off map

Open yanivagman opened this issue 3 years ago • 1 comments
trafficstars

Initial Checklist

  • [ ] There is an issue describing the need for this PR.
  • [x] Git log contains summary of the change.
  • [x] Git log contains motivation and context of the change.
  • [ ] If part of an EPIC, PR git log contains EPIC number.
  • [ ] If part of an EPIC, PR was added to EPIC description.

Description (git log)

To save map lookups and space, remove bufs_off map

Fixes: #issue_number

Type of change

  • [ ] Bug fix (non-breaking change fixing an issue, preferable).
  • [ ] Quick fix (minor non-breaking change requiring no issue, use with care)
  • [x] Code refactor (code improvement and/or code removal)
  • [ ] New feature (non-breaking change adding functionality).
  • [ ] Breaking change (cause existing functionality not to work as expected).

How Has This Been Tested?

Manually

Tests being included in this PR:

  • [ ] Test File A
  • [ ] Test File B

Reproduce the test by running:

  • command 01
  • command 02

Final Checklist:

Pick "Bug Fix" or "Feature", delete the other and mark appropriate checks.

  • [ ] I have made corresponding changes to the documentation.
  • [x] My code follows the style guidelines (C and Go) of this project.
  • [x] I have performed a self-review of my own code.
  • [x] I have commented all functions/methods created explaining what they do.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] My changes generate no new warnings.
  • [] I have added tests that prove my fix, or feature, is effective.
  • [x] New and existing unit tests pass locally with my changes.
  • [x] Any dependent changes have been merged and published before.

Git Log Checklist:

My commits logs have:

  • [x] Subject starts with "subsystem|file: description".
  • [x] Do not end the subject line with a period.
  • [x] Limit the subject line to 50 characters.
  • [x] Separate subject from body with a blank line.
  • [x] Use the imperative mood in the subject line.
  • [x] Wrap the body at 72 characters.
  • [x] Use the body to explain what and why instead of how.

yanivagman avatar Jun 26 '22 20:06 yanivagman

Moving to the next milestone because tests are pretty much done for this release and this change could change stability (about to be released).

rafaeldtinoco avatar Jul 07 '22 12:07 rafaeldtinoco