node-pushnotifications

node-pushnotifications copied to clipboard

Hey,

we just updated from v.1.6.0 to 1.6.2 and found that our notifications on iOS were not working anymore (didn't get the locArgs correctly). We found that according to your latest changes we had to provide a JSON string instead of an Array as parameter. Fixing that resolved the issue on iOS, however, Android suddenly stopped working (no notifications delivered to the device anymore). Honestly, I'm not quite sure why this is the case. According to the documentation of node-gcm and what has been discussed in #150, I can understand the change. However, it's not working for us with the new version. Btw: the non-legacy FCM API requires an usual Array instead of a stringified JSON array (see https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages#AndroidNotification.FIELDS.body_loc_args). Maybe it has something to do with that.

For now we fixed the version to 1.6.0 and that's working fine. @alex-friedl do you have any ideas?

Thanks and best, Pascal

@pascaljung for my understanding: with version 1.6.0 you passed an array to locArgs, which worked fine for both gcm and apn, and after the update to 1.6.2 you changed this to a stringified array, but that broke the gcm/Android integration for you?

I also checked the docs of node-gcm and Firebase again and it appears that passing a stringified array should be correct?

Not sure if maybe the update to node-gcm 1.0.4 broke things somehow? But judging from their commit history, it shouldn't have. But just to make sure, could you test version 1.6.1, where we still use node-gcm 1.0.3 ?

@pascaljung Any update on this? Do you still have the same issue with 1.6.1?

Hi @alex-friedl, sorry didn't get to it yet :(. I'll give you an update once I've tried it

@pascaljung Any update? :)