router
router copied to clipboard
apollographql
v0.11.0: plugin initialization errors: insta snapshot failures for traced_basic_composition and traced_basic_request
After fixing the plugin handler initialisation issue, we were planning to cut a new release. However, after the fix was integrated we noticed intermittent errors in two of the snapshot generating tests:
integration_tests__traced_basic_composition and integration_tests__traced_basic_request
These tests use insta snapshotting to compare the spans generated when the tests are run. The issue is that both tests generate different results when executed (without change to environment or code) which makes our CI tests fail. This only appears to affect MacOS testing.
At this time, we aren't sure of the issue is a real issue in our code or an issue in the testing code which generates snapshots as input to insta.
We don't want to cut a new release until this is resolved and since we know that 0.11.0 is broken, we recommend staying on 0.10.0 until this issue is addressed.
#1410 is a workaround until we figure out exactly what is failing and why. We believe the tracing switch from lazy_static to once_cell may be the cause. I'll check
Closing since telemetry has evolved a fair bit since, and we don't need those tests to assert against snapshots anymore.
This ticket is still linked here: https://github.com/apollographql/router/blob/dev/apollo-router/Cargo.toml#L105
Is that no longer relevant?
Will be updated in this PR https://github.com/apollographql/router/pull/2040/files#diff-aca654efc6c22bebf4bd167370ab3bf380f3e086befe3d7c6761a8f7eb59d89cL182
