router icon indicating copy to clipboard operation
router copied to clipboard

Published 20 hours ago • verified publisher icon apollographql

do not recalculate DashMap's default shard amount on every new map

Open Geal opened this issue 3 years ago • 5 comments

Fix #1366

small optimization that will reduce the number of syscalls (Dashmap recalculates the shard amount from the cgroup at creation but does not save the value anywhere)

Geal avatar Jul 07 '22 13:07 Geal

@Geal your pull request is missing a changelog!

github-actions[bot] avatar Jul 07 '22 13:07 github-actions[bot]

perf test please

Geal avatar Jul 07 '22 14:07 Geal

perf test please

Geal avatar Jul 07 '22 16:07 Geal

perf test please

o0Ignition0o avatar Jul 12 '22 08:07 o0Ignition0o

this will be replaced by the fix for https://github.com/xacrimon/dashmap/issues/219 directly in dashmap

Geal avatar Jul 21 '22 13:07 Geal

closing this because DashMap 5.4.0 was released with a fix for that and added to the router in https://github.com/apollographql/router/commit/01512853c25441b1dcd58a51562aa8677e37b73e

Geal avatar Aug 31 '22 08:08 Geal