clj-antlr icon indicating copy to clipboard operation
clj-antlr copied to clipboard

Add support for deps.edn / publish the Java classes as a separate jar

Open ieugen opened this issue 4 years ago • 2 comments

Hello,

I would like to see support for deps.edn for this project. The feature I find most appealing is the ability to use git versions https://clojure.org/reference/deps_and_cli#_dependencies .

This will allow users (me :D) to use unreleased versions (from git branches to test things out).

I've done the work to build a deps.edn (not that hard). The only blocker are the 3 java classes since Clojure needs those compiled.

I asked on Slack and the current solutions are:

  • compile and commit the classes in the project
  • publish a jar file with the java dependencies
  • remove them (replace them with clojure variants)

I think option 2 is the simplest / best long term IMO but I don't care that much.

NOTE: I know the classes use packages from org.antlr namespace and this should probably change to be aligned with java modules.

@aphyr : What is your take on this? Would you be ok with publishing a small Jar for the 3 classes (optionally with a changed package for the 2 org.antlr )

ieugen avatar Dec 28 '20 21:12 ieugen

Huh, I really don't know anything about deps.edn or how to compare these solutions. Honestly, I'm out of the loop on java modules too, so uhhhh

I really don't know. Since I'm not using clj-antlr myself, I'm open to whatever option involves minimal work on my part, haha. ;-)

aphyr avatar Dec 29 '20 16:12 aphyr

If you're just testing... you know about lein install and checkouts, right?

aphyr avatar Dec 29 '20 16:12 aphyr