pie_chart icon indicating copy to clipboard operation
pie_chart copied to clipboard

Flutter 3 issue

Open fennelhans opened this issue 3 years ago • 5 comments

In Flutter 3, WidgetsBinding.instance no longer requires a null safety check.

: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
../…/pie_chart/pie_chart.dart:42
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../bin/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
    WidgetsBinding.instance?.addPostFrameCallback((_) {

fennelhans avatar May 12 '22 14:05 fennelhans

This is how other teams are solving it: (WidgetsBinding.instance as WidgetsBinding).addObserver(this);

fennelhans avatar May 13 '22 21:05 fennelhans

Thanks for help @fennelhans . Shall fix soon

apgapg avatar May 19 '22 10:05 apgapg

I tried running example app on flutter 3.0.1 but couldn't find any issue.

apgapg avatar May 22 '22 06:05 apgapg

I tried running example app on flutter 3.0.1 but couldn't find any issue.

they changed WidgetBinding.instance null-aware checking operator issue into a warning (it was classified as an exception during build with flutter 3.0.0 and would prevent compilation before 3.0.1). It still shows up as a warning during debug


: Warning: Operand of null-aware operation '?.' has type 'WidgetsBinding' which excludes null.
../…/pie_chart/pie_chart.dart:42
- 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../../Documents/flutter/packages/flutter/lib/src/widgets/binding.dart').
package:flutter/…/widgets/binding.dart:1
    WidgetsBinding.instance?.addPostFrameCallback((_) {
                   ^

mahoraz avatar Jun 20 '22 06:06 mahoraz

Pie chart doesnt use WidgetsBinding. I dont see any warning when running project locally on latest flutter

apgapg avatar Jul 05 '22 03:07 apgapg