tomcat icon indicating copy to clipboard operation
tomcat copied to clipboard

Published 20 hours ago • verified publisher icon apache

Enable to disable request/error counters and cache stats

Open rmannibucau opened this issue 2 years ago • 2 comments

rmannibucau avatar Jan 24 '23 13:01 rmannibucau

This seems like a lot of code to avoid two addition operations.

What's the use-case, here?

ChristopherSchultz avatar Jul 12 '23 20:07 ChristopherSchultz

@ChristopherSchultz mainly reduce the associated overhead (cpu - cas - and mem - in no luck case multiple cells are allocated per context) since most of the time these counters are useless as such - it is not rare to either not use them at all or duplicate them in a monitoring solution. In terms of code it is only ~30LoC, rest is the enablement of the counters. Agree it is not critical - why I didnt push it much more, but it is overall weird to enable by default such things and has a cost and is not easy to drop since it is in this particular valve - it would be another it could be dropped, wich can be a better option maybe?

rmannibucau avatar Jul 12 '23 21:07 rmannibucau