thrift icon indicating copy to clipboard operation
thrift copied to clipboard

THRIFT-5600: upgrade rust toolchain to 1.61 and edition 2021 & THRIFT-5606: Wrong indent for const double

Open OmmyZhang opened this issue 3 years ago • 3 comments

I have tried to create pr for @Jimexist 's branch to fix pr #2632, but as there are too many changes, finally I decided to open a new pr to bump rust version and fix CI first.

for TRIFT-5606:

  • [x] Did you create an Apache Jira ticket? (not required for trivial changes)
  • [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [ ] Did you squash your changes to a single commit? (not required, but preferred)
    • please use squash when finally merging it
  • [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

OmmyZhang avatar Jul 17 '22 12:07 OmmyZhang

~~Now there are problems with D. It seems that I should create a new Jira ticket.~~

Try to fix THRIFT-5608

OmmyZhang avatar Jul 18 '22 07:07 OmmyZhang

@Jimexist thanks!

By the way, can I disable ssl test for java and create a jira, to fix CI? (Seems there are also other problems, not sure, just want to try

OmmyZhang avatar Jul 20 '22 10:07 OmmyZhang

@Jimexist thanks!

By the way, can I disable ssl test for java and create a jira, to fix CI? (Seems there are also other problems, not sure, just want to try

looks like a plan to me!

jimexist avatar Aug 03 '22 09:08 jimexist