thrift

thrift copied to clipboard

• [x] Did you create an Apache Jira ticket? (not required for trivial changes)
• [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• [x] Did you squash your changes to a single commit? (not required, but preferred)
• [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
• [x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

The following packages have unmet dependencies:
 erlang : Depends: erlang-odbc
E: Unable to correct problems, you have held broken packages.
The command '/bin/sh -c apt-get install -y --no-install-recommends   `# Erlang dependencies`   erlang &&   wget https://s3.amazonaws.com/rebar3/rebar3 -O /usr/bin/rebar3 &&   chmod 755 /usr/bin/rebar3 &&   rebar3 --version' returned a non-zero code: 100

Still broken. Also there is a possible conflict with #2541 ahead.

Still broken. Also there is a possible conflict with #2541 ahead.

yes so let me wait for that to merge first and then rebase & fix

i think the latest CI fails because ubuntu:focal ships with openSSL 1.1.1f instead of 1.1.1 in e.g. xenial. This requires some test changes.

cc @jeking3 the original author of SecurityTest. The failing tests is https://app.travis-ci.com/github/apache/thrift/jobs/567449611 - i am not sure if we need to drop some support or need to update the way parameters are constructed

probably need to be done after:

• #2588 is merged first

@Jens-G do you think this can be merged? the refresh script did run correctly. the main errors are the same with master, i.e. Java errors, for which I'm trying to find time to fix.

+1

FYI @Jens-G @fishy or anyone who's interested, i'm merging this, given the current state of CI, i'd rather be iterating towards this (plus bionic) and move away from xenial.

I would really appreciate if we could squash commits that belong together again before merging. And label it with the ticket number, btw.

I would really appreciate if we could squash commits that belong together again before merging. And label it with the ticket number, btw.

thanks for the suggestion, i'd make sure to follow it next time.

I would really appreciate if we could squash commits that belong together again before merging. And label it with the ticket number, btw.

I just double checked that I indeed used GitHub's squash commit button, and the hash is f027deeaa8bf21769d83a35ac37ede21f035c0ad which is a single commit onto master. it only shows here in the pull request as a multi-commit pull request while in the master branch it's one. Did i miss anything?