solr icon indicating copy to clipboard operation
solr copied to clipboard

SOLR-16995: Configure follower behaviour for each replica type

Open pvcnt opened this issue 2 years ago • 2 comments

https://issues.apache.org/jira/browse/SOLR-16995

Description

I am resuming refactoring started earlier (#1928, #1981, #2039) with the goal of simplifying/centralising code related to replica types. The end goal would be to avoid having if (replicaType == Replica.Type.*) scattered across the codebase, and to make it easier to add new replica types.

Solution

This PR adds new attributes to replica types that specify how they behave when they are followers, i.e., the leader replica forwards updates to them.

Tests

Existing tests should pass, no change of behaviour.

Checklist

Please review the following and check all that apply:

  • [x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [x] I have created a Jira issue and added the issue ID to my pull request title.
  • [x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [x] I have developed this patch against the main branch.
  • [x] I have run ./gradlew check.
  • [ ] I have added tests for my changes.
  • [ ] I have added documentation for the Reference Guide

pvcnt avatar Jan 17 '24 15:01 pvcnt

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Apr 23 '24 00:04 github-actions[bot]

This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the [email protected] mailing list. Thank you for your contribution!

github-actions[bot] avatar Jul 04 '24 00:07 github-actions[bot]

This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again.

github-actions[bot] avatar Oct 07 '24 00:10 github-actions[bot]