pulsar
pulsar copied to clipboard
[fix][function-worker] Fix load trust certificate
Signed-off-by: Zixuan Liu [email protected]
Motivation
When brokerClientAuthenticationEnabled=false, the function worker doesn't load the trust certificate.
Modifications
- Always load the trust certificate
Documentation
Check the box below or label this PR directly.
Need to update docs?
-
[ ]
doc-required(Your PR needs to update docs and you will update later) -
[x]
doc-not-needed(Please explain why) -
[ ]
doc(Your PR contains doc changes) -
[ ]
doc-complete(Docs have been already added)
@codelipenghui This is not easy to test for the function worker, a lot of mock tests are used here.
We can make an integration test to cover that but need to open the TLS port in the integration test.
@nodece Any updates?
@nodece Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.
@nodece Any updates?
Rebased, please help review.
The test cannot be added temporarily.
Please clean up the code.
Also...do we have any test case about this feature?
I remember we haven't tested for this, I'm working on adding integration tests for all modules, see #17141.