openwhisk-client-go icon indicating copy to clipboard operation
openwhisk-client-go copied to clipboard

Published 20 hours ago • verified publisher icon apache

swagger schema hardocded and references ibm properties

Open rabbah opened this issue 7 years ago • 7 comments

This schema should not include IBM specific properties:

See https://github.com/apache/incubator-openwhisk-client-go/blob/1759868a61729708a8ab1a6de1b409d6e2aea00a/whisk/api.go#L153-L154

I think the entire struct should be removed anyway - it overly restricts the schema unnecessarily.

rabbah avatar May 20 '18 01:05 rabbah

Why? this limits are applicable and valid to open source gateway

csantanapr avatar May 20 '18 10:05 csantanapr

They are not ibm specific

csantanapr avatar May 20 '18 10:05 csantanapr

The fields are hard coded and called “x-ibm-...“ as in:

x-ibm-configuration x-ibm-rate-limit

rabbah avatar May 20 '18 10:05 rabbah

Yeah for backwards compatibility the it can x-ibm or “x- something else” don’t remember right now what’s the other option for the same

csantanapr avatar May 20 '18 15:05 csantanapr

Both work in the api gateway

csantanapr avatar May 20 '18 15:05 csantanapr

There are no references to XConfig or XRateLimit in the project - how about we remove them... actually I'd remove the entire class, I don't think these types help much anyway and just over constrain the schema ---- or as shown several times, they get out of sync.

rabbah avatar May 21 '18 16:05 rabbah

See ongoing discussion here: https://github.com/apache/incubator-openwhisk-client-go/pull/88

rabbah avatar May 21 '18 18:05 rabbah