maven icon indicating copy to clipboard operation
maven copied to clipboard

[MNG-7520] Simplify integration of Redisson and Hazelcast for Maven R…

Open michael-o opened this issue 3 years ago • 5 comments

…esolver

This closes #776

Following this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Run mvn clean verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • [ ] You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

michael-o avatar Jul 23 '22 22:07 michael-o

@jebeaudet have a look

michael-o avatar Jul 23 '22 22:07 michael-o

Am unsure about the "worthiness" of this PR.... I mean, will someone really want to use Hazelcast AND Redisson? IMHO, this is -0 as am pretty sure people will "stick" to one or another, and also, there is file locking...

cstamas avatar Jul 29 '22 20:07 cstamas

Am unsure about the "worthiness" of this PR.... I mean, will someone really want to use Hazelcast AND Redisson? IMHO, this is -0 as am pretty sure people will "stick" to one or another, and also, there is file locking...

It is not about having BOTH in place. It shalls imply reduce manual setup and simplification of our documentation. Both are contained to handle both cases, NOT at the same time. Even for testing with a new Maven version I have to perform these stupid manual tests over and over again.

michael-o avatar Jul 29 '22 20:07 michael-o

Note that this does not include any JARs, just the skeleton to make it happen.

michael-o avatar Jul 29 '22 20:07 michael-o

@cstamas how should I continue here? This is a reasonable simplification for everyone wants to use either one.

michael-o avatar Aug 04 '22 14:08 michael-o

@cstamas Is my reasoning clear on this?

michael-o avatar Aug 20 '22 20:08 michael-o