logging-log4j2

logging-log4j2 copied to clipboard

Missing/Faulty Logic in AbstractConfiguration for addLoggerAppender / addLoggerFilter / setLoggerAdditive

1

AbstractConfiguration (Log4j 2.24.1) It *seems* there is some missing/faulty logic in the AbstractConfiguration for the methods `addLoggerAppender`, `addLoggerFilter`, `setLoggerAdditive`. These methods all use the `Map.putIfAbsent(key, value)` to only add a...

JWT007

Implements an event service and demonstrates its use for sending/receiving SSL key/trust store changes

3

Intended as a means to discuss what the implementation for https://github.com/apache/logging-log4j2/issues/3074#issuecomment-2446935514 should look like ## Checklist * Base your changes on `2.x` branch if you are targeting Log4j 2; use...

MichaelMorrisEst

CompositeConfiguration merges into the root node of the first configuration instead of using its own root-node

1

Log4j 2.24..3 ---- The composite configuration uses the root-node of the first configuration in the provided list as the basis for the merge of all configurations. ``` rootNode = configurations.get(0).getRootNode();...

JWT007

RegexReplacement static factory method doesn't handle null 'replacement' attribute correctly

2

RegexReplacement#createRegexReplacement Static builder method returns `null`if the `regex`attribute is null, but although it logs an error it does not return `null` if the `replacement` attribute is `null`. ``` public static...

JWT007

LoggerConfig.RootLogger.Builder#withtFilter (typo in method name / only partially fixed)

3

**Log4j 2.24** In LoggerConfig.Builder, an original typo existed in the '`withtFilter`' method (extra 't' in name). This was fixed by deprecating the original method and adding the correct 'withFilter' method....

JWT007

AbstractConfiguration#initialize - making two passes generates invalid configuration - no check if initialization has already been performed

1

Log4j 2.24.3 ------ Repeated calls to the `Configuration#doConfigure` method discard appenders (and maybe other inforrmation). In my example, I have a configuration with two defined appenders ("CONSOLE" and "RollingFile"). Taken...

JWT007

DefaultConfigurationBuilder - is not final but cannot be practically extended due to (in)visibility of private fields

4

Log4j 2.24..3 ---- The DefaultConfigurationBuilder is not final but it practically not extensible because access to the root and other components is private. This implementation could benefit from a bit...

JWT007

Compiling on Module Path with -Werror and -Xlint:all

4

This is about getting an error like the following when compiling with a `module-info.java` and the compiler flags `-Xlint:all` and `-Werror`: ``` > Compilation failed; see the compiler output below....

jjohannes

3399/create logger no lock

1

This PR includes and supersedes https://github.com/apache/logging-log4j2/pull/3418 It fixes the issue of dangling `WeakReference`s, which are not being replaced causing excessive write lock acquisition by introducing a (very limited) `WeakValuesHashMap` to...

tristantarrant

As showed by [this SO question](https://stackoverflow.com/q/79389054/11748454) users might be quite surprised by the error message printed, when no Log4j API implementation is present (or enabled) on the classpath. The message...

ppkarwasz