iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard

Implement Kerberos authentication support for Hive Catalog

Open yothinix opened this issue 1 year ago • 4 comments

Change proposed

  • Introduce support for HMS behind kerberize environment, to enable this feature we need to add catalog config hive.kerberos-authorization=true

Resolves #135

yothinix avatar May 24 '24 10:05 yothinix

Hi @Fokko I added new change as commented, could you help review it again

Also, As I tested more on HMS behind Kerberize we found out that it's required the thrift client to be re-create every time we open a new connection, So that the implementation was change a bit to handle this case. The mentioned change is in this commit https://github.com/apache/iceberg-python/pull/766/commits/a7b8b1c5daa8bdc9ed66153d224ea24e9c438d74

yothinix avatar Jun 11 '24 14:06 yothinix

LGTM+1

I had something very similar to this patched locally. It would be good to get merged asap

awdavidson avatar Jun 27 '24 11:06 awdavidson

Hi @yothinix do you mind rebasing with main? I think this is very close to being merged, I can work with you to get it through.

kevinjqliu avatar Aug 09 '24 16:08 kevinjqliu

Hi @kevinjqliu Thank you for look into this PR, I just rebased the PR branch to latest main branch as requested.

yothinix avatar Aug 17 '24 02:08 yothinix

It would be really great if this could make it into 0.8. :)

uniqueinput avatar Oct 24 '24 21:10 uniqueinput

hi @yothinix thanks for the contribution. Would love like to address the comment above? Would be great to have this as part of the 0.9.0 release

kevinjqliu avatar Feb 01 '25 00:02 kevinjqliu

THanks @yothinix for the contribution, this is merged at #1634

kevinjqliu avatar Feb 12 '25 19:02 kevinjqliu