iceberg-python icon indicating copy to clipboard operation
iceberg-python copied to clipboard

Move snapshot history expire table properties to constants

Open ndrluis opened this issue 1 year ago • 2 comments

I will be opening some PRs that will make it possible to implement the expire snapshot procedure. To make it easier to review, I'm breaking it down into smaller PRs.

ndrluis avatar Oct 03 '24 22:10 ndrluis

@kevinjqliu, please take a look. I have tried many solutions, and this is the best I could come up with. The problem is that any import in this module triggers the deprecation message. The lesson I learned is to never have a constant at the module level. It’s better to namespace constants within classes, so we can deprecate them by simply creating a function as a property.

ndrluis avatar Oct 04 '24 18:10 ndrluis

oh no, sorry for making this more difficult than it should be :( I think its okay to do this without the deprecation steps, but let's see what others think cc @sungwy @HonahX

kevinjqliu avatar Oct 04 '24 18:10 kevinjqliu