drill icon indicating copy to clipboard operation
drill copied to clipboard

DRILL-8117: Clean up deprecated Apache code in Drill

Open kingswanwho opened this issue 3 years ago • 4 comments

DRILL-8117: Clean up deprecated Apache code in Drill

Description

Cleaned up deprecated code of drill-common, due to some UT code of drill-exec referenced to drill-common, so the code of drill-exec was cleaned either.

Documentation

The replaced code references to the recommendation from the deprecated code comments.

Testing

N/A

kingswanwho avatar Mar 20 '22 05:03 kingswanwho

Hi @kingswanwho @paul-rogers We're getting ready to release Drill 1.20.2 which is a minor bugfix release. Is this PR ready to be merged and if so should it be included?

cgivre avatar Jul 08 '22 12:07 cgivre

@cgivre, looking over this PR I think it falls closer to cleanup than it does to bugfix. While it no doubt carries only a little regression risk, it also also offers no benefits to stable release users - it's we Drill devs that will benefit from it - so my vote here is that it is not backported and is merged only into master...

jnturton avatar Jul 11 '22 08:07 jnturton

@cgivre, looking over this PR I think it falls closer to cleanup than it does to bugfix. While it no doubt carries only a little regression risk, it also also offers no benefits to stable release users - it's we Drill devs that will benefit from it - so my vote here is that it is not backported and is merged only into master...

@jnturton I'm fine with that. I guess my question is can we merge it?

cgivre avatar Jul 19 '22 00:07 cgivre

Hi @kingswanwho everything here looks good to me, let's just see if we can replace the ALTER SYSTEMs with client.alterSystems.

jnturton avatar Sep 08 '22 09:09 jnturton

I think this one is licked! I've requested a review from @cgivre to get it a once over from a pair of eyes belonging to a non-author.

jnturton avatar Feb 13 '23 10:02 jnturton

Let me see what's gone awry with the Hive tests...

jnturton avatar Feb 13 '23 11:02 jnturton

Let me see what's gone awry with the Hive tests... @jnturton Did you do a rebase with DRILL-8398 and DRILL-8400?

cgivre avatar Feb 13 '23 12:02 cgivre

@jnturton Did you do a rebase with DRILL-8398 and DRILL-8400?

I did think of that and now have, thanks.

jnturton avatar Feb 13 '23 13:02 jnturton

The Hive unit tests are quite problematic for me locally due to more problems than you'd expect when I try to do test runs under JDK 8. Anyway, I think that I've fixed the two broken Hive impersonation tests and rebased on master in this new PR to your branch.

jnturton avatar Feb 13 '23 16:02 jnturton

The Hive unit tests are quite problematic for me locally due to more problems than you'd expect when I try to do test runs under JDK 8. Anyway, I think that I've fixed the two broken Hive impersonation tests and rebased on master in this new PR to your branch.

I have merged and pushed, it should work well this time : -)

kingswanwho avatar Feb 13 '23 16:02 kingswanwho

@jnturton @kingswanwho I'll review once CI passes later today. Looks good so far!

cgivre avatar Feb 13 '23 16:02 cgivre

@kingswanwho Looks like we're still getting some errors on the Hive unit tests. I'm rerunning to see if it was a fluke or not.

cgivre avatar Feb 13 '23 19:02 cgivre

@kingswanwho @jnturton It looks like Java 8 is still not liking the Hive unit tests.

cgivre avatar Feb 14 '23 01:02 cgivre

Hi Charles, Thanks for the remind! Need James' help to investigate.

kingswanwho avatar Feb 14 '23 01:02 kingswanwho