drill
drill copied to clipboard
DRILL-8117: Clean up deprecated Apache code in Drill
DRILL-8117: Clean up deprecated Apache code in Drill
Description
Cleaned up deprecated code of drill-common, due to some UT code of drill-exec referenced to drill-common, so the code of drill-exec was cleaned either.
Documentation
The replaced code references to the recommendation from the deprecated code comments.
Testing
N/A
Hi @kingswanwho @paul-rogers We're getting ready to release Drill 1.20.2 which is a minor bugfix release. Is this PR ready to be merged and if so should it be included?
@cgivre, looking over this PR I think it falls closer to cleanup than it does to bugfix. While it no doubt carries only a little regression risk, it also also offers no benefits to stable release users - it's we Drill devs that will benefit from it - so my vote here is that it is not backported and is merged only into master...
@cgivre, looking over this PR I think it falls closer to cleanup than it does to bugfix. While it no doubt carries only a little regression risk, it also also offers no benefits to stable release users - it's we Drill devs that will benefit from it - so my vote here is that it is not backported and is merged only into master...
@jnturton I'm fine with that. I guess my question is can we merge it?
Hi @kingswanwho everything here looks good to me, let's just see if we can replace the ALTER SYSTEMs with client.alterSystems.
I think this one is licked! I've requested a review from @cgivre to get it a once over from a pair of eyes belonging to a non-author.
Let me see what's gone awry with the Hive tests...
Let me see what's gone awry with the Hive tests... @jnturton Did you do a rebase with DRILL-8398 and DRILL-8400?
@jnturton Did you do a rebase with DRILL-8398 and DRILL-8400?
I did think of that and now have, thanks.
The Hive unit tests are quite problematic for me locally due to more problems than you'd expect when I try to do test runs under JDK 8. Anyway, I think that I've fixed the two broken Hive impersonation tests and rebased on master in this new PR to your branch.
The Hive unit tests are quite problematic for me locally due to more problems than you'd expect when I try to do test runs under JDK 8. Anyway, I think that I've fixed the two broken Hive impersonation tests and rebased on master in this new PR to your branch.
I have merged and pushed, it should work well this time : -)
@jnturton @kingswanwho I'll review once CI passes later today. Looks good so far!
@kingswanwho Looks like we're still getting some errors on the Hive unit tests. I'm rerunning to see if it was a fluke or not.
@kingswanwho @jnturton It looks like Java 8 is still not liking the Hive unit tests.
Hi Charles, Thanks for the remind! Need James' help to investigate.