dolphinscheduler icon indicating copy to clipboard operation
dolphinscheduler copied to clipboard

[Improvement-#11608][task-plugin] New time variables are added to facilitate business development

Open fengjian1129 opened this issue 3 years ago • 8 comments
trafficstars

Purpose of the pull request

close #11608

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

fengjian1129 avatar Aug 26 '22 11:08 fengjian1129

Codecov Report

Merging #11667 (cd4a7a4) into dev (cccbd27) will increase coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head cd4a7a4 differs from pull request most recent head 96afd4f. Consider uploading reports for the commit 96afd4f to get more accurate results

@@             Coverage Diff              @@
##                dev   #11667      +/-   ##
============================================
+ Coverage     39.81%   39.82%   +0.01%     
- Complexity     4718     4719       +1     
============================================
  Files          1002     1002              
  Lines         37872    37872              
  Branches       4230     4230              
============================================
+ Hits          15079    15084       +5     
+ Misses        21192    21185       -7     
- Partials       1601     1603       +2     
Impacted Files Coverage Δ
...erver/master/processor/queue/TaskEventService.java 75.00% <0.00%> (-5.36%) :arrow_down:
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 50.00% <0.00%> (+6.45%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 26 '22 11:08 codecov-commenter

@fengjian1129 Please create an issue first, why we need to do this change.

ruanwenjun avatar Aug 28 '22 13:08 ruanwenjun

@ruanwenjun hi bro,i have created a issue,link:https://github.com/apache/dolphinscheduler/issues/11608 The purpose of adding the time variable is to provide the common business time in the production environment, which will be convenient to use. The original time variable needs multiple calculations. Moreover, in the production environment, the time variables used for business development need to be configured simply and quickly

fengjian1129 avatar Aug 29 '22 02:08 fengjian1129

@ruanwenjun hi bro. can you review the code I submitted.

fengjian1129 avatar Sep 02 '22 06:09 fengjian1129

@EricGao888 look this pr

fengjian1129 avatar Sep 02 '22 06:09 fengjian1129

@caishunfeng @zhongjiajie @zhuangchong hello , Can I submit this PR to the community?

fengjian1129 avatar Sep 13 '22 02:09 fengjian1129

@EricGao888 Code has been updated

fengjian1129 avatar Sep 22 '22 11:09 fengjian1129

@ruanwenjun @caishunfeng @SbloodyS Could u plz help take a look when available? Thanks : )

EricGao888 avatar Sep 23 '22 03:09 EricGao888

@EricGao888 @davidzollo thanks bro

fengjian1129 avatar Sep 24 '22 15:09 fengjian1129

I've restarted failed jobs in CI, LGTM once CI passes.

What do u want me to do ?

fengjian1129 avatar Sep 26 '22 06:09 fengjian1129

I've restarted failed jobs in CI, LGTM once CI passes.

What do u want me to do ?

Nothing actually, just wait for the CI to complete. It seems CI is not very stable recently.

EricGao888 avatar Sep 26 '22 06:09 EricGao888

Nothing actually, just wait for the CI to complete. It seems CI is not very stable recently.

okay, i see. Thanks

fengjian1129 avatar Sep 26 '22 06:09 fengjian1129

@fengjian1129 Good job! This is a handy feature, thanks again for the contribution!

EricGao888 avatar Sep 26 '22 08:09 EricGao888