calcite icon indicating copy to clipboard operation
calcite copied to clipboard

Published 20 hours ago • verified publisher icon apache

[CALCITE-4645] In Elasticsearch adapter, translate a range predicate to a range query(Jacky Yin)

Open yinchuanwang opened this issue 4 years ago • 7 comments
trafficstars

This PR is the following action of PR2420 to implement the translation from range search to range query in elastic search adapter. One specific test class "SearchTest" is added to test the translation from "Search" to terms/range query.

yinchuanwang avatar Jun 10 '21 15:06 yinchuanwang

looks in pretty good shape.

zinking avatar Jun 11 '21 06:06 zinking

looks in pretty good shape.

I have updated the code based on your advice. Any other comments?

yinchuanwang avatar Jun 21 '21 07:06 yinchuanwang

Hello @zinking, do you have time to review the change?

yinchuanwang avatar Jun 23 '21 05:06 yinchuanwang

Hello @amaliujia, It seems that @zinking is not available recently. Do you have time to help review this PR?

yinchuanwang avatar Jul 14 '21 05:07 yinchuanwang

Sure I can try to start taking a look within this week.

amaliujia avatar Jul 14 '21 17:07 amaliujia

Many thanks.

yinchuanwang avatar Jul 15 '21 00:07 yinchuanwang

Hi, @yinchuanwang ! Are you still working on this patch? I've disabled testFilterSortDesc() in ElasticsearchAdapterTest.java through https://github.com/apache/calcite/pull/2659, which could be solved in this patch. Please take a look if you have time, that will be very helpful!

ILuffZhe avatar Jan 04 '22 15:01 ILuffZhe