avro icon indicating copy to clipboard operation
avro copied to clipboard

AVRO-3476: Implement Local Timestamp Logical Types

Open kojiromike opened this issue 4 years ago • 4 comments

Jira

  • [x] My PR addresses AVRO-3476 and references it in the PR title.
  • [x] My PR adds no dependencies.

Tests

  • [ ] My PR still needs more tests.

Commits

  • [x] My commits all reference the Jira issue in the subject line.

Documentation

  • [x] My PR adds new functionality that is already documented in the spec.

kojiromike avatar Apr 05 '22 00:04 kojiromike

@kojiromike I had similar concerns about the absolutness of the long value when I did #1628. Some unit tests would be great to specify the the from /to long conversion between a long and an absolute time (utc) maybe if there is any. If there is none, I am not sure how 2 language implementation can be determinstic in serialization and deserelization.

zcsizmadia avatar Apr 05 '22 01:04 zcsizmadia

Hi @kojiromike , thank you for looking into this issue and spending some time writing this code. Is there anything missing to complete this PR?

cccs-eric avatar May 02 '22 18:05 cccs-eric

Hi, sorry, I'm pretty overloaded with family and work stuff right now. If someone else wants to continue this work that's fine, or if you want to wait I may have some capacity in the future.

kojiromike avatar May 10 '22 15:05 kojiromike

The local timestamp logical types could be added to the interop tests, to verify that the values roundtrip correctly between languages. These tests would then have to be run in an environment where the local time is not UTC, to detect if one language uses UTC for conversions and another uses local time.

KalleOlaviNiemitalo avatar Jul 03 '22 07:07 KalleOlaviNiemitalo