Antonio Mendoza Pérez
Antonio Mendoza Pérez
@mjameswh will this feature, once implemented, allow adding custom tags to Temporal metrics (like workflow id, activity id...)
thanks for the pr @wu-json
It would be nice to have this in the documentation
Thanks @tsurdilo > just see previous comment about it being bit hard to understand / follow. Let me see if I can refactor it / make it simpler > Also...
@tsurdilo I have refactored the code and added some comments This is the commit https://github.com/temporalio/samples-java/pull/567/commits/b2a4f67a7a636c081179dec9179dd9606d5a417d let me know if you find it easier to follow now thanks
@mjameswh the current prometheus example https://github.com/temporalio/samples-python/tree/main/prometheus shows all metrics with temporal_ prefix it uses [python-sdk 1.5.0](https://github.com/temporalio/sdk-python/releases/tag/1.5.0) https://github.com/temporalio/samples-python/blob/6bcab28f85461c13e594ebc15ec3a111533a3ae7/pyproject.toml#L20
@mjameswh I saw your comment in Jira, let me modify this accordingly
@taonic ^^
WIP https://github.com/temporalio/samples-dotnet/pull/40
> I believe adding a parameter is a backwards incompatible operation and is why we encourage using objects where fields can be added instead. Agreed Chad. I can update the...