Salvatore Sanfilippo

Results 127 comments of Salvatore Sanfilippo

Hey folks, since LOLWUT has always hard limits to the arguments that may make it more expensive, it is effectively an O(1) command.

I would say that every LOLWUT version which is not O(1), has a bug.

Maybe we should have a shared sheet with this commands and the time complexity, and work at the list. When looks ok, we can put it into the JSON.

No need for an RCP, no huge design challenges since it's a purely technical stuff, and no API changes. Cheers.

Thanks for clarifying, well if you want to present it as an RCP, it makes sense... for future reference for example, or if the proposal is refused in order to...

p.s. reopening since accepted RCP numbers should have their issue always open so that other can see where we are with the numbering. Also, issue renamed to make it clear...

Hello Bill, I think the section about Sentinel removal is quite confusing, and does not really help to clarify what is going on. I would like to state things in...

Good catch, and good patch, but why

The code looks well written and does not change radically the linenoise code base in order to add such a support, however the question is if it's a fit for...

Hello @romanbsd, I'll check what are the reports that valgrind outputs. I used valgrind less than normally with Rax because it is not able to deal with pointers stored at...