community.vmware

community.vmware copied to clipboard

SUMMARY

Add datacenter argument to vmware_vm_vm_drs_rule module

Code adjustments copy-pasted from vmware_vm_host_drs_rule module

Fixes #2101

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_vm_vm_drs_rule

ADDITIONAL INFORMATION

Previously no datacenter could be provided. The result was that the module always tried to create/manage rules in the first cluster in vcenter that matches the name. Now a datacenter name can be provided if nessessary.

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/3252e3ea0d2e4695861b8b280b53dd7b

:x: ansible-tox-linters FAILURE in 9m 36s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 27s :warning: ansible-test-cloud-integration-vcenter7_only-stable216 CANCELED :warning: ansible-test-cloud-integration-vcenter7_2esxi-stable216 CANCELED :warning: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 CANCELED :warning: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 CANCELED :warning: ansible-galaxy-importer CANCELED

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/c6fa272d51254abd9c998bcd27acee5e

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 35s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 21s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 17m 55s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 13m 58s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 46m 40s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 03m 50s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 24s

We've recently decided to advocate avoid using aliases for module options. I don't think using an alias here is really needed and a valid use case.

Additionally, please add a changelog fragment.

Thanks for your feedback. I have implemented the suggestions you made.

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/39215b4db8984af490ff82d0bc4e7528

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 24s :heavy_check_mark: build-ansible-collection SUCCESS in 10m 27s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 17m 43s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 13m 22s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 51m 20s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 00m 32s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 16s

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/983bb3342351499aba05cd0b3d065ed6

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 29s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 37s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 21m 46s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 18m 04s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 53m 54s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 07m 25s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 03s

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/59755986ffa24e989e5b0ce712365d9f

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 13s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 40s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 29s