community.vmware

community.vmware copied to clipboard

SUMMARY

Fixes https://github.com/ansible-collections/community.vmware/issues/123

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_guest_disk

ADDITIONAL INFORMATION

capacityInKB is of type long, but we have code in place to support float values for the disk size in the module. We should typecast the size by rounding the provided value.

Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/150562409e8640818dcb0c1d96711117

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 25s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 50s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 17m 50s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 13m 47s :x: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 FAILURE in 1h 00m 08s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 59m 19s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 05s

Sorry, I didn't find the time yet to have a look at this. And I'll be AFK for a couple of days, so please bare with me.

Anyway, we've changed the CI to test with ansible-core 2.17 recently (ansible/ansible-zuul-jobs#1875) and I would like to see if your PR works with this. So I'll close it and re-open it in a couple of minutes. Just to make sure that the CI really runs with 2.17.

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/146cba344d344e2ab307dd9b432ddada

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 41s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 39s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 17m 46s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 14m 42s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 45m 03s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 06m 15s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 27s

@dawidd6 Sorry, I didn't have the time to have a closer look at this. I hope I'll be able to, soon.

Meanwhile, could you please add a changelog fragment?

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/ddf67d5e95104e109a3748476a8ed6f3

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 13s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 49s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 17m 25s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 15m 31s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 46m 38s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 02m 43s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 44s

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/8a2c3a2feadf41d6899659787653923b

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 12s :heavy_check_mark: build-ansible-collection SUCCESS in 9m 19s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 17m 47s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 13m 35s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 45m 36s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 08m 24s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 5m 02s

Build succeeded (gate pipeline). https://ansible.softwarefactory-project.io/zuul/buildset/cc5cf342a20e4fbf99f832054c769d47

:heavy_check_mark: ansible-tox-linters SUCCESS in 9m 38s :heavy_check_mark: build-ansible-collection SUCCESS in 7m 49s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 26s