community.vmware

community.vmware copied to clipboard

SUMMARY

Adding support for VM migration in the vmware_guest module.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

When the user is asking for a different hostname, there is no operation handling that. This PR adds the support for VM migration to a different hostname.

Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/9a96d912574f4d5e86e3da81f9e2f155

:heavy_check_mark: ansible-tox-linters SUCCESS in 11m 18s :heavy_check_mark: build-ansible-collection SUCCESS in 11m 54s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 19m 18s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 19m 37s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 51m 11s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 55m 01s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 13s

@mariolenz can you review it please?

@bardielle Are you really sure about this? This module is already far too complex IMHO, and there's vmware_vmotion for people who want to move a VM to another host.

At the moment, I'm desperately trying to find ways making this module simpler instead of adding even more features (read: complexity) to it.

I don't think I'll merge this. The module is already far too complex.

I'll close this PR for now. Feel free to open it again, but if you do do please also join the conversation in Refactoring community.vmware.vmware_guest in vmware.vmware.