community.vmware

community.vmware copied to clipboard

SUMMARY

ISSUE TYPE

• Docs Pull Request
• Feature Pull Request

COMPONENT NAME

vmware_guest_sendkey

ADDITIONAL INFORMATION

Build failed.

:heavy_check_mark: ansible-tox-linters SUCCESS in 4m 00s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 02s :heavy_check_mark: ansible-test-sanity-docker-devel SUCCESS in 7m 23s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 8m 06s :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 30s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 12s :heavy_check_mark: ansible-test-units-community-vmware-python38 SUCCESS in 5m 09s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 14s :x: ansible-test-cloud-integration-vcenter7_2esxi-stable212 RETRY_LIMIT in 6m 40s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 39m 29s :x: ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 FAILURE in 12m 40s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 01s

recheck

Build failed.

:heavy_check_mark: ansible-tox-linters SUCCESS in 4m 20s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 15s :heavy_check_mark: ansible-test-sanity-docker-devel SUCCESS in 9m 08s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 8m 37s :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 29s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 01s :heavy_check_mark: ansible-test-units-community-vmware-python38 SUCCESS in 5m 04s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 29s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 17m 47s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 39m 08s :x: ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 FAILURE in 23m 13s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 10s

I looked at the failed zuul run and at first sight, I do not think I should feel responsible for its failure, or should I?

recheck

Build failed.

:heavy_check_mark: ansible-tox-linters SUCCESS in 4m 06s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 13s :heavy_check_mark: ansible-test-sanity-docker-devel SUCCESS in 9m 29s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 7m 40s :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 29s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 49s :heavy_check_mark: ansible-test-units-community-vmware-python38 SUCCESS in 5m 02s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 08s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 17m 11s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 38m 19s :x: ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 FAILURE in 24m 28s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 29s

Build failed.

:x: ansible-tox-linters FAILURE in 3m 58s :x: build-ansible-collection FAILURE in 3m 04s :warning: ansible-test-sanity-docker-devel SKIPPED (non-voting) :warning: ansible-test-sanity-docker-milestone SKIPPED :warning: ansible-test-sanity-docker-stable-2.12 SKIPPED :warning: ansible-test-sanity-docker-stable-2.13 SKIPPED :warning: ansible-test-units-community-vmware-python38 SKIPPED :warning: ansible-test-cloud-integration-vcenter7_only-stable212 SKIPPED :warning: ansible-test-cloud-integration-vcenter7_2esxi-stable212 SKIPPED :warning: ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SKIPPED :warning: ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SKIPPED :warning: ansible-galaxy-importer SKIPPED

I adapted the documentation describing my proposed PR and made a small change on handling letters in key combinations. I put it into a separate commit. It it gains approval I would squash my commits before the merge.

Build failed.

:heavy_check_mark: ansible-tox-linters SUCCESS in 4m 01s :x: build-ansible-collection FAILURE in 2m 59s :warning: ansible-test-sanity-docker-devel SKIPPED (non-voting) :warning: ansible-test-sanity-docker-milestone SKIPPED :warning: ansible-test-sanity-docker-stable-2.12 SKIPPED :warning: ansible-test-sanity-docker-stable-2.13 SKIPPED :warning: ansible-test-units-community-vmware-python38 SKIPPED :warning: ansible-test-cloud-integration-vcenter7_only-stable212 SKIPPED :warning: ansible-test-cloud-integration-vcenter7_2esxi-stable212 SKIPPED :warning: ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SKIPPED :warning: ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SKIPPED :warning: ansible-galaxy-importer SKIPPED

recheck

Build failed.

:heavy_check_mark: ansible-tox-linters SUCCESS in 4m 04s :heavy_check_mark: build-ansible-collection SUCCESS in 4m 07s :heavy_check_mark: ansible-test-sanity-docker-devel SUCCESS in 9m 03s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 8m 23s :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 45s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 57s :heavy_check_mark: ansible-test-units-community-vmware-python38 SUCCESS in 5m 35s :x: ansible-test-cloud-integration-vcenter7_only-stable212 RETRY_LIMIT in 1h 00m 44s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 17m 58s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 39m 02s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 57m 11s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 55s

recheck

Build succeeded.

:heavy_check_mark: ansible-tox-linters SUCCESS in 4m 01s :heavy_check_mark: build-ansible-collection SUCCESS in 3m 56s :heavy_check_mark: ansible-test-sanity-docker-devel SUCCESS in 8m 27s (non-voting) :heavy_check_mark: ansible-test-sanity-docker-milestone SUCCESS in 8m 05s :heavy_check_mark: ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 22s :heavy_check_mark: ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 48s :heavy_check_mark: ansible-test-units-community-vmware-python38 SUCCESS in 5m 58s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 18m 20s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 16m 31s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 42m 44s :heavy_check_mark: ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 57m 15s :heavy_check_mark: ansible-galaxy-importer SUCCESS in 4m 08s

finally, everything is green. 🎉

This is ready for review!

Hi @mariolenz, I've seen you checking in here before. Can you review this?

Hi @mariolenz, I've seen you checking in here before. Can you review this?

Sure, but there are so many other things to do :-(

But I'll try to find the time to review your PR, it's definitively on my Todo list.

@jason-neumann Would it be possible for you to test this PR? It looks like it adds support for ALT+TAB and some more goodies.

Unfortunately, I don't use this module myself. So I don't have any real-world examples to test this.

But it looks like you do. It would be great to hear from you whether a) ALT+TAB works for you with these changes and b) they don't break anything for you.