community.aws
community.aws copied to clipboard
Fix aws_ssm when Powershell uses CLIXML
SUMMARY
This PR adds the code suggested by @PatrickV-code on #1952
In short, connection to Windows based EC2 instances using aws_ssm connection and using the become option of runas fails every job. The job itself actually finishes, but as Powershell 5 adds additional wrapping with CLIXML information. Which makes the output unreadable for Ansible.
ISSUE TYPE
- Bugfix Pull Request
COMPONENT NAME
aws_ssm
Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/10299bc8bfee46b4813d1914ac4c663b
:x: ansible-galaxy-importer FAILURE in 5m 07s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 15m 47s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 42s :heavy_check_mark: integration-community.aws-1 SUCCESS in 14m 29s :heavy_check_mark: integration-community.aws-2 SUCCESS in 10m 23s :heavy_check_mark: integration-community.aws-3 SUCCESS in 12m 56s :heavy_check_mark: integration-community.aws-4 SUCCESS in 10m 39s :heavy_check_mark: integration-community.aws-5 SUCCESS in 9m 34s :heavy_check_mark: integration-community.aws-6 SUCCESS in 21m 06s :heavy_check_mark: integration-community.aws-7 SUCCESS in 9m 39s :heavy_check_mark: integration-community.aws-8 SUCCESS in 13m 26s :heavy_check_mark: integration-community.aws-9 SUCCESS in 8m 24s :heavy_check_mark: integration-community.aws-10 SUCCESS in 9m 25s :x: integration-community.aws-11 RETRY_LIMIT in 1m 40s Skipped 11 jobs
recheck
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/12fba0d2eb194190a2889c90949793b9
:x: ansible-galaxy-importer FAILURE in 5m 37s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 15m 37s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 14s :heavy_check_mark: integration-community.aws-1 SUCCESS in 10m 55s :heavy_check_mark: integration-community.aws-2 SUCCESS in 8m 01s :heavy_check_mark: integration-community.aws-3 SUCCESS in 9m 16s :heavy_check_mark: integration-community.aws-4 SUCCESS in 9m 06s :heavy_check_mark: integration-community.aws-5 SUCCESS in 9m 32s :heavy_check_mark: integration-community.aws-6 SUCCESS in 9m 36s :heavy_check_mark: integration-community.aws-7 SUCCESS in 9m 12s :heavy_check_mark: integration-community.aws-8 SUCCESS in 10m 08s :heavy_check_mark: integration-community.aws-9 SUCCESS in 8m 24s :heavy_check_mark: integration-community.aws-10 SUCCESS in 9m 50s :heavy_check_mark: integration-community.aws-11 SUCCESS in 9m 45s Skipped 11 jobs
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/e7aa5cf2526747598eaa972a26842fc9
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 6m 35s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 16m 01s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 42s :heavy_check_mark: integration-community.aws-1 SUCCESS in 11m 03s :heavy_check_mark: integration-community.aws-2 SUCCESS in 9m 12s :heavy_check_mark: integration-community.aws-3 SUCCESS in 10m 29s :heavy_check_mark: integration-community.aws-4 SUCCESS in 10m 21s :heavy_check_mark: integration-community.aws-5 SUCCESS in 9m 52s :heavy_check_mark: integration-community.aws-6 SUCCESS in 19m 58s :heavy_check_mark: integration-community.aws-7 SUCCESS in 10m 34s :heavy_check_mark: integration-community.aws-8 SUCCESS in 13m 42s :heavy_check_mark: integration-community.aws-9 SUCCESS in 8m 15s :heavy_check_mark: integration-community.aws-10 SUCCESS in 9m 48s :heavy_check_mark: integration-community.aws-11 SUCCESS in 5m 21s Skipped 11 jobs
@tremble I fixed the issue with black, should be ready to be rechecked.
Build succeeded. https://ansible.softwarefactory-project.io/zuul/buildset/215ffe60682f46a38df68e5b778548bb
:x: ansible-galaxy-importer FAILURE in 5m 25s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 16m 29s :heavy_check_mark: ansible-test-splitter SUCCESS in 6m 43s :heavy_check_mark: integration-community.aws-1 SUCCESS in 10m 22s :heavy_check_mark: integration-community.aws-2 SUCCESS in 9m 18s :heavy_check_mark: integration-community.aws-3 SUCCESS in 9m 50s :heavy_check_mark: integration-community.aws-4 SUCCESS in 10m 41s :heavy_check_mark: integration-community.aws-5 SUCCESS in 10m 00s :heavy_check_mark: integration-community.aws-6 SUCCESS in 19m 21s :heavy_check_mark: integration-community.aws-7 SUCCESS in 9m 17s :heavy_check_mark: integration-community.aws-8 SUCCESS in 11m 56s :heavy_check_mark: integration-community.aws-9 SUCCESS in 9m 06s :heavy_check_mark: integration-community.aws-10 SUCCESS in 12m 19s :heavy_check_mark: integration-community.aws-11 SUCCESS in 6m 29s Skipped 11 jobs
Hi @tremble, anything else I can do for this PR?
regate
regate
Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing
https://ansible.softwarefactory-project.io/zuul/buildset/82b72a6197ad42bebffe63736d011238
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 16s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 13m 12s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 25s :x: integration-community.aws-1 FAILURE in 11m 12s :x: integration-community.aws-2 FAILURE in 12m 14s :x: integration-community.aws-3 FAILURE in 11m 44s :x: integration-community.aws-4 FAILURE in 13m 14s :x: integration-community.aws-5 FAILURE in 17m 11s :x: integration-community.aws-6 FAILURE in 11m 15s :x: integration-community.aws-7 FAILURE in 12m 56s :x: integration-community.aws-8 FAILURE in 16m 17s :x: integration-community.aws-9 FAILURE in 14m 22s :x: integration-community.aws-10 FAILURE in 12m 33s :heavy_check_mark: integration-community.aws-11 SUCCESS in 5m 22s Skipped 11 jobs
regate
Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing
https://ansible.softwarefactory-project.io/zuul/buildset/8ba12f476c344df280ae7f2fbd8425df
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 18s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 48s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 09s :x: integration-community.aws-1 FAILURE in 13m 25s :x: integration-community.aws-2 FAILURE in 12m 11s :x: integration-community.aws-3 FAILURE in 13m 10s :x: integration-community.aws-4 FAILURE in 11m 29s :x: integration-community.aws-5 FAILURE in 13m 46s :x: integration-community.aws-6 FAILURE in 10m 24s :x: integration-community.aws-7 RETRY_LIMIT in 7m 42s :x: integration-community.aws-8 FAILURE in 10m 54s :x: integration-community.aws-9 FAILURE in 10m 50s :x: integration-community.aws-10 FAILURE in 11m 37s :heavy_check_mark: integration-community.aws-11 SUCCESS in 4m 07s Skipped 11 jobs
regate
Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing
https://ansible.softwarefactory-project.io/zuul/buildset/bb093155316a42a5aec0fe8b68204601
:x: ansible-galaxy-importer FAILURE in 4m 12s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 13s :heavy_check_mark: ansible-test-splitter SUCCESS in 4m 53s :x: integration-community.aws-1 FAILURE in 13m 43s :x: integration-community.aws-2 FAILURE in 11m 58s :x: integration-community.aws-3 FAILURE in 11m 29s :x: integration-community.aws-4 FAILURE in 13m 24s :x: integration-community.aws-5 FAILURE in 11m 02s :x: integration-community.aws-6 FAILURE in 13m 12s :x: integration-community.aws-7 FAILURE in 15m 33s :x: integration-community.aws-8 FAILURE in 13m 12s :x: integration-community.aws-9 FAILURE in 13m 46s :x: integration-community.aws-10 FAILURE in 11m 20s :heavy_check_mark: integration-community.aws-11 SUCCESS in 7m 11s Skipped 11 jobs
2024-06-28 19:10:40.087341 | controller | "msg": "timed out waiting for ping module test: 'ping'"
regate
Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing
https://ansible.softwarefactory-project.io/zuul/buildset/148de36d24f44b7ea38235154ff29725
:x: ansible-galaxy-importer FAILURE in 4m 52s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 24s :heavy_check_mark: ansible-test-splitter SUCCESS in 4m 52s :x: integration-community.aws-1 FAILURE in 13m 25s :x: integration-community.aws-2 FAILURE in 11m 56s :x: integration-community.aws-3 FAILURE in 14m 49s :x: integration-community.aws-4 FAILURE in 13m 28s :x: integration-community.aws-5 FAILURE in 15m 40s :x: integration-community.aws-6 FAILURE in 11m 55s :x: integration-community.aws-7 FAILURE in 14m 56s :x: integration-community.aws-8 FAILURE in 13m 17s :x: integration-community.aws-9 FAILURE in 15m 22s :x: integration-community.aws-10 FAILURE in 12m 18s :heavy_check_mark: integration-community.aws-11 SUCCESS in 4m 18s Skipped 11 jobs
regate
Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing
https://ansible.softwarefactory-project.io/zuul/buildset/fb9b7b6c0cbd401ea1c7b78694adf512
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 3m 51s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 51s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 24s :x: integration-community.aws-1 FAILURE in 10m 56s :x: integration-community.aws-2 FAILURE in 11m 16s :x: integration-community.aws-3 FAILURE in 12m 05s :x: integration-community.aws-4 FAILURE in 12m 49s :x: integration-community.aws-5 FAILURE in 13m 20s :x: integration-community.aws-6 FAILURE in 13m 04s :x: integration-community.aws-7 FAILURE in 10m 30s :x: integration-community.aws-8 FAILURE in 13m 24s :x: integration-community.aws-9 FAILURE in 12m 25s :x: integration-community.aws-10 FAILURE in 12m 22s :heavy_check_mark: integration-community.aws-11 SUCCESS in 4m 56s Skipped 11 jobs
regate
Build failed (gate pipeline). For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing
https://ansible.softwarefactory-project.io/zuul/buildset/5aa159cb29b6465a9871ee073c02f187
:heavy_check_mark: ansible-galaxy-importer SUCCESS in 8m 02s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 37s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 36s :x: integration-community.aws-1 FAILURE in 15m 04s :x: integration-community.aws-2 FAILURE in 13m 38s :x: integration-community.aws-3 FAILURE in 13m 23s :x: integration-community.aws-4 FAILURE in 11m 21s :x: integration-community.aws-5 FAILURE in 13m 16s :x: integration-community.aws-6 FAILURE in 13m 05s :x: integration-community.aws-7 FAILURE in 12m 33s :x: integration-community.aws-8 FAILURE in 12m 33s :x: integration-community.aws-9 FAILURE in 11m 44s :x: integration-community.aws-10 FAILURE in 12m 38s :heavy_check_mark: integration-community.aws-11 SUCCESS in 5m 29s Skipped 11 jobs
Hi @markuman @alinabuzachis, is there something I need to change for the build to succeed?
Hi @markuman @alinabuzachis, is there something I need to change for the build to succeed?
I'm not sure. Error message is
TASK [wait_for_connection] *****************************************************
task path: /home/zuul-worker/.ansible/collections/ansible_collections/community/aws/tests/integration/targets/connection/test_connection.yml:14
fatal: [linux_i-0b10c2ed71e4a0682]: FAILED! => {
"changed": false,
"elapsed": 101,
"msg": "timed out waiting for ping module test: 'ping'"
}
gateing CI failed, while the check for the PR succeeded.
recheck
Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/4294d8d51e1e4ecaaefe8faf9cebaa3f
:x: ansible-galaxy-importer FAILURE in 4m 24s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 12m 19s :heavy_check_mark: ansible-test-splitter SUCCESS in 5m 05s :x: integration-community.aws-1 FAILURE in 12m 19s :x: integration-community.aws-2 FAILURE in 16m 41s :x: integration-community.aws-3 FAILURE in 12m 01s :x: integration-community.aws-4 FAILURE in 12m 01s :x: integration-community.aws-5 FAILURE in 17m 59s :x: integration-community.aws-6 FAILURE in 12m 01s :x: integration-community.aws-7 FAILURE in 12m 22s :x: integration-community.aws-8 FAILURE in 17m 18s :x: integration-community.aws-9 FAILURE in 13m 07s :x: integration-community.aws-10 FAILURE in 17m 22s :heavy_check_mark: integration-community.aws-11 SUCCESS in 5m 00s Skipped 11 jobs
@markuman @alinabuzachis I merged the latest commits from main into this PR, hopefully that fixes the checks?
Build failed. https://ansible.softwarefactory-project.io/zuul/buildset/8d31e08832694f828a111f97df9691fd
:x: ansible-galaxy-importer FAILURE in 4m 38s (non-voting) :heavy_check_mark: build-ansible-collection SUCCESS in 10m 36s :heavy_check_mark: ansible-test-splitter SUCCESS in 4m 14s :x: integration-community.aws-1 FAILURE in 12m 15s :x: integration-community.aws-2 FAILURE in 12m 51s :x: integration-community.aws-3 FAILURE in 12m 40s :x: integration-community.aws-4 FAILURE in 13m 29s :x: integration-community.aws-5 FAILURE in 13m 26s :x: integration-community.aws-6 FAILURE in 12m 22s :x: integration-community.aws-7 FAILURE in 12m 50s :x: integration-community.aws-8 FAILURE in 13m 43s :x: integration-community.aws-9 FAILURE in 12m 53s :x: integration-community.aws-10 FAILURE in 12m 33s :heavy_check_mark: integration-community.aws-11 SUCCESS in 5m 54s Skipped 11 jobs
@markuman @alinabuzachis I don't follow why the build doesn't succeed.
The edits work when I use them on my AWS instance.
It seems like something was changed between https://github.com/ansible-collections/community.aws/pull/2080#issuecomment-2079959483 and https://github.com/ansible-collections/community.aws/pull/2080#issuecomment-2196930063, but not the code of this PR.
This PR looks promising for resolving the CLIXML handling issue in aws_ssm with PowerShell. Our team has been eagerly waiting for this fix as it would significantly streamline our workflows. Thank you for the continuous efforts! Looking forward to seeing this merged soon. If there’s any way we can help or test further, please let us know.
recheck