namada icon indicating copy to clipboard operation
namada copied to clipboard

Published 20 hours ago • verified publisher icon anoma

more checked arith and other lints

Open tzemanovic opened this issue 1 year ago • 2 comments

Describe your changes

closes #2555

Indicate on which release or other PRs this topic is based on

0.35.1

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

tzemanovic avatar May 09 '24 13:05 tzemanovic

Codecov Report

Attention: Patch coverage is 75.46174% with 186 lines in your changes are missing coverage. Please review.

Project coverage is 60.26%. Comparing base (4ed6229) to head (860132b).

Files Patch % Lines
crates/namada/src/vm/host_env.rs 82.01% 25 Missing :warning:
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 60.52% 15 Missing :warning:
crates/namada/src/ledger/vp_host_fns.rs 63.33% 11 Missing :warning:
crates/tx/src/types.rs 68.57% 11 Missing :warning:
crates/apps/src/lib/node/ledger/shell/mod.rs 70.96% 9 Missing :warning:
crates/governance/src/cli/validation.rs 0.00% 9 Missing :warning:
crates/apps/src/lib/config/genesis/chain.rs 33.33% 8 Missing :warning:
crates/apps/src/lib/node/ledger/mod.rs 0.00% 8 Missing :warning:
crates/namada/src/ledger/mod.rs 38.46% 8 Missing :warning:
crates/proof_of_stake/src/epoched.rs 50.00% 8 Missing :warning:
... and 22 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3214      +/-   ##
==========================================
+ Coverage   60.24%   60.26%   +0.01%     
==========================================
  Files         303      303              
  Lines       93191    93455     +264     
==========================================
+ Hits        56145    56322     +177     
- Misses      37046    37133      +87

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 14:05 codecov[bot]

Looks good to me in general, just left a couple questions.

thx! I fixed all the issues in https://github.com/anoma/namada/compare/ec36ae148190e183c70cc0c56171aa3bb8b1d359..31e54b9fcccb58d5628cc0362597d5848b576796

tzemanovic avatar May 14 '24 15:05 tzemanovic