namada icon indicating copy to clipboard operation
namada copied to clipboard

namada/vm: disable floats in wasm

Open tzemanovic opened this issue 1 year ago • 5 comments

Describe your changes

closes #1872

Indicate on which release or other PRs this topic is based on

0.35.1

Checklist before merging to draft

  • [x] I have added a changelog
  • [x] Git history is in acceptable state

tzemanovic avatar May 09 '24 09:05 tzemanovic

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.24%. Comparing base (4ed6229) to head (7f3a04c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3209      +/-   ##
==========================================
- Coverage   60.24%   60.24%   -0.01%     
==========================================
  Files         303      303              
  Lines       93191    93191              
==========================================
- Hits        56145    56143       -2     
- Misses      37046    37048       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 10:05 codecov[bot]

can we move ibc back to wasm now?

Fraccaman avatar May 09 '24 11:05 Fraccaman

can we move ibc back to wasm now?

@Fraccaman I'm not sure, it was an issue with M1/M2 which might still be there (https://github.com/anoma/namada/issues/1831)

tzemanovic avatar May 09 '24 12:05 tzemanovic

@yito88 do u know if we can compile ibc-rs to wasm now?

Fraccaman avatar May 15 '24 16:05 Fraccaman

@Fraccaman I tried it in #2480 and it worked. I'm not sure whether the latest one works or not. I'll try it with 0.35.1

yito88 avatar May 15 '24 21:05 yito88

tx_ibc.wasm moved back to wasm worked in #3275

yito88 avatar May 22 '24 00:05 yito88