portal icon indicating copy to clipboard operation
portal copied to clipboard

Published 20 hours ago • verified publisher icon anitab-org

Refactor meetup/utils.py

Open SanketDG opened this issue 5 years ago • 8 comments

Description

A lot of code in meetup/utils.py can be refactored, especially the jwt auth exchange

Definition of Done

  • [x] All of the required items are completed.
  • [x] Approval by 1 mentor.

Estimation

3 hours

SanketDG avatar Aug 19 '20 20:08 SanketDG

@SanketDG Can I take this up?

PragatiVerma18 avatar Sep 04 '20 19:09 PragatiVerma18

@PragatiVerma18 Assigned!

SanketDG avatar Sep 05 '20 18:09 SanketDG

@PragatiVerma18 Hi Any updates?

sakshi1499 avatar Sep 21 '20 12:09 sakshi1499

Hello @SanketDG can I take up the issue!

tejaswini22199 avatar Nov 26 '20 09:11 tejaswini22199

Sure! Assigned you @tejaswini22199

sakshi1499 avatar Nov 27 '20 15:11 sakshi1499

@sakshi1499 I removed multiple instances of payload and added only one of them. Can you help me in figuring out why it is failing tests while I'm merging.

tejaswini22199 avatar Nov 27 '20 18:11 tejaswini22199

There was some issue with the last PR merge maybe that is why. Also, Your PR hasn't followed the commit guidelines so there are failing tests. @tejaswini22199

sakshi1499 avatar Nov 28 '20 08:11 sakshi1499

Hello @SanketDG @sakshi1499, I took a look at the PR by @tejaswinii22199 and your comments in that. I understood that we need to create functions for creating tokens and intitialize those tokens at runtime calls. I would like to attempt solving this issue. Could you please assign it to me if it's still open for contribution? Thanks!

sankha555 avatar Dec 27 '20 08:12 sankha555