components icon indicating copy to clipboard operation
components copied to clipboard

fix(cdk/table): row differ does not detect template changes

Open shlomiassaf opened this issue 5 years ago • 5 comments

fixes #20717

shlomiassaf avatar Oct 11 '20 11:10 shlomiassaf

@jelbourn this is my attempt on this one, thanks!

shlomiassaf avatar Oct 11 '20 11:10 shlomiassaf

@jelbourn @andrewseguin This will get old eventually.

Can you review it?

Thanks...

shlomiassaf avatar Dec 01 '20 00:12 shlomiassaf

Just took a look- seems like this got stalled because it's breaking ~10 targets inside of Google and nobody has had the time yet to dig into the failures and debug.

@mmalerba we should do a fresh run and see if the failures aren't too difficult to clear

jelbourn avatar Dec 01 '20 00:12 jelbourn

The errors don't look trivial to resolve. Some of the tests seem to be intentionally verifying that elements are not refreshed. I think we'll need to discuss with someone on that team to figure out what they're trying to accomplish and if we can make it work with this PR.

mmalerba avatar Jan 15 '21 22:01 mmalerba

@shlomiassaf It's really tricky figuring out the internal test failures. If you'd like to rebase, we can continue to try and get them passing

andrewseguin avatar Mar 24 '22 19:03 andrewseguin

I'm closing this PR because there hasn't been any response to the latest comments in close to two years.

crisbeto avatar Feb 28 '24 08:02 crisbeto

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.