components icon indicating copy to clipboard operation
components copied to clipboard

Published 20 hours ago • verified publisher icon angular

fix(tree): allow readonly arrays in getChildren return type

Open crisbeto opened this issue 5 years ago • 2 comments

Fixes not being allowed to return a ReadonlyArray from a getChildren function. Also pulls the definition for the getChildren function into a separate type so we don't have to maintain it in 4 different places.

Fixes #17824.

crisbeto avatar Nov 27 '19 15:11 crisbeto

Turns out that this is a breaking change; anywhere this value is assigned into something else the types don't match now. It has ~60 failing build targets across a bunch of projects

jelbourn avatar Dec 04 '19 04:12 jelbourn

What is the status of this PR? This PR didn't land in neither v10, v11 nor v12 although it is 1.5 years old. A similar PR for chips was merged within a week

thetric avatar Jun 28 '21 07:06 thetric

Closing since the tree is in the process of being reworked.

crisbeto avatar Feb 28 '24 08:02 crisbeto

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

angular-automatic-lock-bot[bot] avatar Mar 30 '24 00:03 angular-automatic-lock-bot[bot]