Andy Wermke
Andy Wermke
Thanks for the PR, @aminya! Can you check why the rollup build is failing?
Thanks, @aminya. Need to sleep about it, though. The issue is that this solution will only work in node.js, it won't work with webpack or parcel bundler.
Need to double-check, but I think the only reason why the test doesn't fail is because the worker doesn't require any bundling when tested in a node.js environment. Background: Parcel...
Sorry, @aminya. Was super busy the last few days… Yeah, maybe it's time to target a more up-to-date JS runtime like ES2017. This tsconfig.json has been around for two years...
Thanks so much, @aminya! I will go through this PR once more in-depth before merging it, but it looks really good.
@aminya Damn, I'm so sorry. Just swamped with work right now… 🙈 Feel free to annoy me on a regular basis as much as you like until this gets shipped....
@manzt The `external` fix sounds plausible. Nice to see that you were able to fix it already! Yes, the `eval()` call is part of the webpack hack 😅 Would you...
Node 12 is out, shipping worker_threads without the feature flag. Might be the right time to get back to this? 😉
Hey Kelly! Hmm, tricky. The error is thrown in the worker in case the initial handshake with the master process fails. Hard to recover from something like that as there...
Good point. Might be a duplicate of #420, though.