go-gerrit

go-gerrit copied to clipboard

1. Fix `FixSuggestions` and `Replacements` types. Now `ReviewInput` fails with `400 Bad Request`. 2. Add endpoints to read robot comments. 3. Additionally, I found that `getCommentInfoMapSliceResponse` and `getCommentInfoMapResponse` are the...

jsarzy

Add support for context package

6

We should think about adding support for the `context` package. I like how go-github is using the context as first parameter: https://github.com/google/go-github/blob/master/github/issues.go#L286

andygrunwald

Craft a new release

2

Once we finished https://github.com/andygrunwald/go-gerrit/issues/100 we should release a new version. See all the changes that happen since the last one: https://github.com/andygrunwald/go-gerrit/compare/0.5.2...master

andygrunwald

Projects.SetConfig endpoint fails with 400 Bad Request due to ConfigInput.MaxObjectSizeLimit zero value not being omitted

5

I create TestProjectsService_SetConfig func to test SetConfig requests api fail error info: failed: 400 Bad Request Invalid application/json in request I find ConfigInput field is MaxObjectSizeLimitInfo, change type string can...

wuhuang26

change MaxObjectSizeLimit type to string Log: Fix problem Invalid application/json in request Fixes #111.

wuhuang26

Fix handling of Skip and Start parameters for pagination

2

The way how we handle pagination is not optimal, partially broken, and sometimes even inconsistent with the current (v3.4.1) Gerrit REST API docs. **Not optimal** Parameters are defined as strings...

andygrunwald

Document missing OpenAPI/Swagger-Defintion/API-Spec

2

One thought would be if we can generate this client. An API Spec file would be required for it. A few discussions have been ongoing, but no progress/merge yet regarding...

andygrunwald

Since the last release (v0.5.2), a lot of changes happened. We should update the CHANGELOG.md with a proper migration path in case of breaking changes. See https://github.com/andygrunwald/go-gerrit/compare/0.5.2...master For the format,...

andygrunwald

Hello? <crickets>

6

Hopefully everyone is alive and well, no COVID-19 infections, etc. I was just wondering if any future changes are planned on this project? Yes, I know, I can fork it,...

JalonSolov

labels should not be pre-escaped

3

Gerrit syntax [allows to query for approval scores](https://gerrit-review.googlesource.com/Documentation/user-search.html#labels), so something like the following is possible: `status:open label:verified=+1,user=jenkins` For all open changesets that were `+1`'d by a user named `jenkins`. Due...

flokli