Andy Hook

Results 58 comments of Andy Hook
trafficstars

Posting as a reminder, two good options for composition depending on requirements: Composing dialog outside of content: https://codesandbox.io/s/dropdownmenu-dialog-nszobq?file=/src/App.js Composing dialog inside content (preventing close and visually hiding): https://codesandbox.io/s/magical-grass-j85kbz?file=/src/App.js

I'm unable to reproduce on MacOS or virtualised windows. I'll leave this open for now pending time in the future to investigate further.

> What are the differences between this dropdown and the one on the Dropdown Menu page, that could cause this difference in latency? Hard to say without looking into it...

Hey @hoop71 , thanks for raising. Seems the new popper logic isn’t updating unless the physical dimensions of the floating element change or we resize the window. That would explain...

Thanks for this @hipstersmoothie , I left [a follow up](https://github.com/radix-ui/primitives/pull/1597#issuecomment-1255952703) in the linked PR explaining our current position regarding changes to these options.

Related https://github.com/radix-ui/primitives/issues/1616#issuecomment-1217722992

Closing this issue due to lack of activity, feel free to follow up with more information about the request though.

@Dan5py These types of performance warnings depend on many variables including complexity of page, performance of client and other factors, there might be more we can do to optimise but...

> and handling body-scroll-locking manually I'm also curious whether the upcoming [native scrollbar-gutter](https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter) would show a big improvement on these large pages.