media icon indicating copy to clipboard operation
media copied to clipboard

Unwanted TV support in manifest, feature or bug?

Open borek2 opened this issue 1 year ago • 4 comments

Since the update to exoplayer-ima version 2.19.1, our Android app unexpectedly activates the Leanback feature. The Leanback feature is defined in the manifest of exoplayer-ima, and unless explicitly removed using node:remove, our app automatically utilizes the Leanback feature.

This behavior is causing our mobile app to be displayed on Android TV devices instead of the dedicated Android TV app version included in our bundle. This is undesirable and not intended.

Is this expected behaviour or is this a bug?

borek2 avatar Jan 29 '24 19:01 borek2

Apparantly it's not exoplayer, its com.google.android.tv:tv-ads which exoplayer depends on.

borek2 avatar Jan 29 '24 19:01 borek2

Re-opening for awareness. Can't find a repo for com.google.android.tv:tv-ads.

borek2 avatar Jan 29 '24 20:01 borek2

Thanks for reporting!

Apparantly it's not exoplayer, its com.google.android.tv:tv-ads which exoplayer depends on.

Can you elaborate how ExoPlayer depends on com.google.android.tv:tv-ads? When I search the project for com.google.android.tv I can not find that we directly depend on it. It may be caused by a transitive dependency, but I can't find an obvious culprit.

Can you give me a nudge where we introduce this dependency?

marcbaechinger avatar Feb 05 '24 11:02 marcbaechinger

Ah, I see. This is pulled in by the new IMA SDK. I agree this should not automatically modify the app manifest.

marcbaechinger avatar Feb 05 '24 11:02 marcbaechinger

any update on it?

HGaurav328 avatar Mar 09 '24 16:03 HGaurav328

+1 Bump, any resolution?

arslancb avatar Apr 04 '24 20:04 arslancb

Internal bugref: b/333028226

marcbaechinger avatar Apr 05 '24 09:04 marcbaechinger

This was reported to the IMA team. This requires to be fixed in the dependency. Once this is fixed we can bump the IMA SDK version.

marcbaechinger avatar Apr 05 '24 09:04 marcbaechinger

We've found this issue as well :( Are any solution to fix it without waiting for bump the IMA SDK ?

glebkacode avatar Apr 08 '24 18:04 glebkacode

UPD: We're resolved this by exclude tv-ads dependencies in result builds!

glebkacode avatar Apr 12 '24 09:04 glebkacode