nowinandroid icon indicating copy to clipboard operation
nowinandroid copied to clipboard

Published 20 hours ago • verified publisher icon android

Use Chrome Custom tab for opening articles

Open calren opened this issue 2 years ago • 3 comments

Before change: before.webm

After: after.webm

calren avatar Nov 29 '22 21:11 calren

I haven't had time to review this but just wanted to say this is looking sweet 👌

dturner avatar Nov 29 '22 23:11 dturner

There's similar code in NewsResourceCardList.kt, do we want to update that as well?

https://github.com/android/nowinandroid/blob/56b3c1d0b950ed27051424ca6718743d7a3c6b97/core/ui/src/main/java/com/google/samples/apps/nowinandroid/core/ui/NewsResourceCardList.kt#L50-L51

alexvanyo avatar Dec 02 '22 18:12 alexvanyo

ah yes, good catch Alex - fixed by implementing in NewsResourceCardList as well!

calren avatar Dec 02 '22 20:12 calren