architecture-components-samples icon indicating copy to clipboard operation
architecture-components-samples copied to clipboard

Reformat BasicRxJavaSample

Open DevDengChao opened this issue 6 years ago • 3 comments

  • Override equals() and hashCode() to User
  • Migrate from deprecated classes and methods, eg: InstrumentationRegistry.getContext() -> ApplicationProvider.getApplicationContext()
  • Add @NotNull and @Nullable annotations
  • Reformat and rearrange.

DevDengChao avatar May 29 '19 14:05 DevDengChao

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar May 29 '19 14:05 googlebot

I signed it!

DevDengChao avatar May 29 '19 14:05 DevDengChao

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar May 29 '19 14:05 googlebot

Closed as outdated.

DevDengChao avatar Jul 25 '23 08:07 DevDengChao