Andrew Hickman
Andrew Hickman
I think this is possible with the current `prost_build` API by: - Create a `FileDescriptorSet` from the `FileDescriptorProto` instances - Write it to a temporary file - Set [`file_descriptor_set_path`](https://docs.rs/prost-build/latest/prost_build/struct.Config.html#method.file_descriptor_set_path) and...
I've implemented JSON serialization and deserialization in [prost_reflect](https://docs.rs/prost-reflect/latest/prost_reflect/). It passes all the protobuf conformance tests so I'd consider it "complete", although it would be great to get some real-world testing...
I just noticed there was a previous, quite similar attempt at this in #117 . This is PR is a bit more conservative in that it doesn't change any existing...
Reopening this since I noticed unknown fields were mentioned in #624 . I don't personally need this functionality any more but hopefully it can be useful as a starting point
> I feel like len should be captured in that uninterpreted_option, which I should be able to parse via (missing?) functionality in the FieldDescriptorProto extension? I might be able to...
It seems like this could be fixed by flushing before (or after) every winapi call?
Its worth noting that all uses of `Into` are for constructing an `fs_err::File`, which owns a PathBuf even in the happy path. All the other functions were changed to `AsRef`...
[FileTypeExt::is_symlink_dir](https://doc.rust-lang.org/stable/std/os/windows/fs/trait.FileTypeExt.html#tymethod.is_symlink_dir) is stable as of Rust 1.64.0. It would be a shame to impose a MSRV just for this, but maybe this could be implemented as an optional feature
`DirBuilder` would certainly make sense to wrap, especially since we already provider a wrapper for `tokio::fs::DirBuilder`. It looks like the fallible methods on `Metadata` only fail if the platform doesn't...
Merging `Name` into `Message` might be problematic for custom Message implementations like [`prost_reflect::DynamicMessage`](https://docs.rs/prost-reflect/latest/prost_reflect/struct.DynamicMessage.html), unless the string types were changed to something like `Cow