Andrew Godwin

Results 343 comments of Andrew Godwin

No worries - it might take me some time to get to this, unfortunately, as it's a very complex PR and reviewing it is going to take a lot of...

I do agree somewhat with Jon here - the sheer work required to make this polymorphic to every possible callable type maybe takes away from its understandability (I've tried three...

What would an ASGI server do with this information though? I don't think it's useful outside of test cases, is it not?

(i.e. - is the proposal to add this to a response message and have servers ignore it?)

I agree with @davidism. If we're going to have a "test info please ignore" extension, let's make it more generic and nest template information inside it. It's worth noting that...

So, if this is an extension I think I'm happy with it conceptually and we should make sure we agree on a name for it that's not `.template` and then...

I might suggest `http.debug_info` or `http.test_info` so that it's clear it's not for communication with normal servers?

Agreed, that makes it clearer that it's for testing only. Let's go with that. Do you want to write the PR to add it to the spec?

Daphne was always a reference server - a "true" ASGI server is going to be uvicorn or hypercorn. I also don't maintain this any more, we instead have other people...

What would you expect to happen - that everything shares the same context (both in and outside the sync_to_async/async_to_sync calls)? I believe that is what the intended effect is, but...