Andrew Culver

Results 66 comments of Andrew Culver

@tleish Yes, 100%. Seems like this would be a major improvement!

@tleish Hey, I just realized this probably won't work. You can't inject the JS until you're ready to start recording, which shouldn't happen until the user has actually hit `magic_test`...

Actually, I take that back... it _could_ work, we just need to add a method to activate the recording, vs. it happening automatically, then issue that command via JS when...

We've got an update on the JS side coming that will help support this.

@tleish Hey, sorry to drop the ball on this. Forget what I said before! I would definitely be interested in your approach. Want to take a stab at it?

[Added a Wiki page](https://github.com/bullet-train-co/magic_test/wiki/NameError:-undefined-local-variable-or-method-'magic_test') to cover the possibility of this happening, but obviously want to get to the bottom of this.

@kaspth Want to take a stab at resolving the conflicts?

@coolprobn This is close, but there's a big issue: The JS fires the reminder even during normal running of system tests, which breaks the entire Bullet Train test suite. Instead,...

@coolprobn Also, please make sure the Bullet Train test suite is passing when linked to this branch for it's `magic_test` dependency in the `Gemfile`.

@kaspth This works for me!