nordic.nvim icon indicating copy to clipboard operation
nordic.nvim copied to clipboard

add config option for transparency

Open shxfee opened this issue 2 years ago • 4 comments

This colorscheme is awesome! If you could add support for transparency it will be perfect!

shxfee avatar Feb 06 '23 20:02 shxfee

Glad to hear you like it!

I'll look into it :)

On Mon, 6 Feb 2023, 21:55 Hussain Shafeeu, @.***> wrote:

This colorscheme is awesome! If you could add support for transparency it will be perfect!

— Reply to this email directly, view it on GitHub https://github.com/andersevenrud/nordic.nvim/issues/92, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABHODHTBT53EAXHUFHWJQTWWFQK5ANCNFSM6AAAAAAUTEY7XY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

andersevenrud avatar Feb 06 '23 21:02 andersevenrud

I've opened a PR for this if you want to try it out: #93

Would be nice if it was tested by someone else, because I don't really know what's expected of transparency support 😅 But I have at least made the obvious ones toggleable.

andersevenrud avatar Feb 12 '23 19:02 andersevenrud

Thanks for this. Here are a few highlight groups that still has background color.

      NormalFloat
      Float
      FloatBorder
      SignColumn
      Pmenu

I actually decided to write an autocommand to remove bg from colorschemes so I don't have to worry about colorschemes supporting it. I ll leave it here for reference.

-- transparent backgrounds
vim.api.nvim_create_autocmd("Colorscheme", {
  callback = function ()
    local groups = {
      "Normal",
      "NormalNC",
      "NormalFloat",
      "Float",
      "FloatBorder",
      "SignColumn",
      "GitSignsAdd",
      "GitSignsChange",
      "GitSignsDelete",
      "Pmenu",
      -- "PmenuSel", need to fix this for tokyonight
      "WinSeparator",
      "TelescopeNormal",
      "TelescopeBorder",
      "TelescopeSelection",
      "TelescopePreviewNormal",
      "WhichKeyFloat",
    }

    for _, group in ipairs(groups) do
      vim.cmd("hi " .. group .. " ctermbg=None guibg=NONE")
    end

    -- dim fg for WinSeparator
    vim.cmd("hi WinSeparator guifg=#4e4d5e")
  end,
  group = mygroup,
  desc = "Transparent backgrounds",
})

shxfee avatar Feb 26 '23 07:02 shxfee

I've updated the ones missing from the list you wrote down.

Not sure why these aren't working as expected though, since they do use the transparency option 🤔

      Float
      FloatBorder
      SignColumn

Using an autocommand is a really nice way to solve this 👍 I've seen some plugins out there that provides this.

andersevenrud avatar Mar 02 '23 18:03 andersevenrud