torrent icon indicating copy to clipboard operation
torrent copied to clipboard

Support changing seeding config after initialization

Open ghost opened this issue 4 years ago • 12 comments

How can I do it? There is ClientConfig.Seed but how can I change it during runtime ?

ghost avatar May 04 '21 10:05 ghost

This will need to be exposed. It probably wouldn't hurt to expose stuff like download/upload ratio too to enable users to make use of that in configuring seeding.

anacrolix avatar May 06 '21 00:05 anacrolix

Can you please expose seed and download/upload ratio ?

ghost avatar May 06 '21 11:05 ghost

I will look into it if I have time, cheers.

anacrolix avatar May 07 '21 10:05 anacrolix

Hello, what's the progress on this? also, to change iplist.Ranger , should we lock client's mutex before changing? if yes, can you please create wrapper function to perform so?

ghost avatar May 17 '21 07:05 ghost

Sorry, I'm not working on this currently.

anacrolix avatar May 17 '21 08:05 anacrolix

This remains a valid enhancement. Possibly related to https://github.com/anacrolix/torrent/issues/155.

anacrolix avatar May 18 '21 02:05 anacrolix

@anacrolix , Possible workarounds include ranging through torrents in client and if they are completed, disable data upload

ghost avatar May 18 '21 05:05 ghost

Yeah, there are definitely workarounds. Good thinking.

anacrolix avatar May 19 '21 00:05 anacrolix

https://github.com/anacrolix/torrent/blob/b21aebeaae6a308d97e9f952c78639bc594e73fd/torrent.go#L1363

So, Config is directly been referenced. so,it would be easy to implement this feature,no?

ghost avatar May 19 '21 17:05 ghost

@anacrolix can you provide method to change Seed value of config(while mutex locking it) ?

It must solve this issue.right?

ghost avatar Jun 19 '21 09:06 ghost

Yes that would work. There might be a few condition values to tickle or something too.

anacrolix avatar Jun 23 '21 03:06 anacrolix

https://github.com/anacrolix/torrent/pull/527 @anacrolix

gitpubber avatar Jun 30 '21 12:06 gitpubber